Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL suppport #13

Closed
jayabie opened this issue Sep 19, 2022 · 11 comments
Closed

RTL suppport #13

jayabie opened this issue Sep 19, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@jayabie
Copy link

jayabie commented Sep 19, 2022

Hell Team,

Does this software support RTL?
if not, do you have any manual for development purposes.
I'm interested in running a community based on this with RTL support.
@evgip
Copy link
Collaborator

evgip commented Sep 20, 2022

Until now, there have been no requests to support this mode. Let me see what can be done, how to add it.

@evgip evgip added the enhancement New feature or request label Sep 20, 2022
@jayabie
Copy link
Author

jayabie commented Sep 20, 2022

I will work on the translation at my free time, once i finish i will pass all the files to your dev email.
i just want to help with this.

@jayabie
Copy link
Author

jayabie commented Oct 3, 2022

Hello @evgip ,

I thought would be better if i share the link with you instead of sending to email.
please the link below for complete Arabic localization.

https://we.tl/t-Mhm386szxZ

the original language file is from September 24th, i don`t know if you guys added new words, but i will check a track them.

@evgip
Copy link
Collaborator

evgip commented Oct 3, 2022

@jayabie

Thank you very much! I will check everything and the files will be included in the release. If there are any questions, I will contact you.

Thanks again!

@jayabie
Copy link
Author

jayabie commented Oct 5, 2022

I did some test on a local environment
i have mirrored the base CSS using the tool below and. added it to rtl.css
The tool: https://rtlcss.com/playground/index.html#

Also, i added dir="rtl" to the line below.
<html lang="ar" prefix="og: http://ogp.me/ns# article: http://ogp.me/ns/article# profile: http://ogp.me/ns/profile#" dir="rtl">

the mirroring went fine, except the text box couldn`t sent to the right and still doesn't support the mixed characters.

i just did this as a test, i don't know if this will help you by some way as I'm not a coding person myself😉 .

a screenshot below.

image

@evgip
Copy link
Collaborator

evgip commented Oct 5, 2022 •
edited
Loading

@jayabie

We can add the following code to the editor to enable support:

<?php if (Translate::getLang() == 'ar') : ?>direction: 'rtl',<?php endif; ?>

I'll look into it. Haven't done it yet, but it's on the roadmap. I plan to support in a future release. Thank you.

evgip added a commit that referenced this issue Oct 5, 2022
@evgip
DEV: Поддержка RTL в редакторе
f4cf0b8 
#13
@jayabie
Copy link
Author

jayabie commented Oct 6, 2022 •
edited
Loading

Hello @evgip,

This last commit you made above yesterday.
f4cf0b8

sent the website to the right and fixed the mixed characters, but the icons are nested with the text, and the user menu is going out of screen. see the below:
image

Like yesterday i have mirrored the base CSS and added to rtl.css through my browser console.
the icons nested with the text issue fixed, but the user menu is still going out generating a horizontal scroll bar.
see the below picture after i mirrored the CSS code.
image

I know you are not focusing on this at this time, but I'm writing this as a reference for the future when you decide to spare the time to achieve RTL. its just part of my test results.

@evgip
Copy link
Collaborator

evgip commented Oct 6, 2022

@jayabie Thanks a lot. This is a big topic, it should definitely be dealt with in the future.

@jayabie
Copy link
Author

jayabie commented Oct 9, 2022 •
edited
Loading

Hello @evgip,

Is there any possibility i get the access to libarea/app/Languages/ar/ in this repository?
after i re-installed the version where Arabic is implemented and found that some words need improvement, they are not wrong but as i said needs improvement.
so, i believe having the access that that folder only will make it easy i improve these words without downloading the language folder every time.

if this possible and will not cause any security issues i appreciate if you grant me the access to ar folder only, i don`t need access to any other folders as I'm not a coder and i can't help with coding things.

Also, is not necessary i get the access to the folder in this repository if you have any other way i can improve the translation with less work, all is i need to make the localization better and better for this awesome software.

@evgip
Copy link
Collaborator

evgip commented Oct 9, 2022 •
edited
Loading

@jayabie

I wanted to contact you about RTL support. Is there any way to contact you other than GitHub?

My email address: budo@narod.ru
Or Discord Chat: https://discord.gg/adJnPEGZZZ

P.S. I am currently preparing the localization in a separate repository on GitHub to facilitate the work.

@jayabie
Copy link
Author

jayabie commented Oct 9, 2022

Hello @evgip,

Done, i have sent you an email and joined the channel on discord.
you are free to contact me through anyone of these you want.

evgip added a commit that referenced this issue Oct 15, 2022
@evgip
DEV: RTL suppport
1d58e38 
#13
evgip added a commit that referenced this issue Oct 17, 2022
@evgip
DEV: RTL suppport (2)
2b068b8 
#13
evgip added a commit that referenced this issue Oct 23, 2022
@evgip
DEV: RTL suppport (3)
cc07651 
См. #13
evgip added a commit that referenced this issue Oct 24, 2022
@evgip
DEV: RTL suppport (4)
3ca3bb9 
См. #13
@evgip evgip closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evgip @jayabie