New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marks the component that is not exported #471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will be marked as a draft until a good solution is found. |
只要不标注“未导出”,用什么样式用户都是猜不出来的(同时灰色+删除线比较好,和abi保持一致) |
应该标注的是“已导出”而不是“未导出”。已导出可能会有安全问题,未导出是一个应用的常规设置,不应特殊标记,字体也不应使用灰色,更不能用删除线。 @Doddddd |
那可以用类似于elf的处理方式,已导出的用主题色标注。 |
现在的界面设计已经不适合增加越来越多越来越复杂的功能呈现了,或许应该考虑二级页面或者更改呈现方式。 |
zhaobozhen
requested changes
Jan 7, 2023
app/src/main/kotlin/com/absinthe/libchecker/ui/fragment/main/AdvancedMenuBSDFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/absinthe/libchecker/view/applist/AdvancedMenuBSDView.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/absinthe/libchecker/viewmodel/DetailViewModel.kt
Outdated
Show resolved
Hide resolved
zhaobozhen
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently set the color of the components that are not exported to gray, but I know this is not the best display scheme.
And I don't have a harmony os device, so the test on harmony os has not be done.