Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks the component that is not exported #471

Merged
merged 12 commits into from Jan 7, 2023

Conversation

qhy040404
Copy link
Member

@qhy040404 qhy040404 commented Oct 26, 2022

I currently set the color of the components that are not exported to gray, but I know this is not the best display scheme.

And I don't have a harmony os device, so the test on harmony os has not be done.

@zhaobozhen
Copy link
Member

telegram-cloud-photo-size-5-6269204212982329683-y
Yes, I think the current presentation is confusing to users and I will keep this PR until a better solution is available.

@qhy040404
Copy link
Member Author

This PR will be marked as a draft until a good solution is found.

@qhy040404 qhy040404 marked this pull request as draft October 31, 2022 14:27
@Doddddd
Copy link

Doddddd commented Dec 5, 2022

只要不标注“未导出”,用什么样式用户都是猜不出来的(同时灰色+删除线比较好,和abi保持一致)
我觉得可以在右上角加入高级菜单,用来筛选未导出、被收录的库和排序

@su1216
Copy link
Contributor

su1216 commented Dec 6, 2022

应该标注的是“已导出”而不是“未导出”。已导出可能会有安全问题,未导出是一个应用的常规设置,不应特殊标记,字体也不应使用灰色,更不能用删除线。 @Doddddd

@qhy040404
Copy link
Member Author

应该标注的是“已导出”而不是“未导出”。已导出可能会有安全问题,未导出是一个应用的常规设置,不应特殊标记,字体也不应使用灰色,更不能用删除线。 @Doddddd

那可以用类似于elf的处理方式,已导出的用主题色标注。

@zhaobozhen
Copy link
Member

现在的界面设计已经不适合增加越来越多越来越复杂的功能呈现了,或许应该考虑二级页面或者更改呈现方式。

@qhy040404 qhy040404 marked this pull request as ready for review January 6, 2023 14:40
@zhaobozhen zhaobozhen merged commit 152513e into LibChecker:master Jan 7, 2023
@qhy040404 qhy040404 deleted the feat/exported branch January 7, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants