Fails to build with GCC-6

[ghost]

> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '128' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '128' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> Makefile:862: recipe for target 'internal/dcraw_common.lo' failed
> make[1]: *** [internal/dcraw_common.lo] Error 1

More info can be found at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811744

[ghost]

maybe someone could propose this patch to dcoffin: https://gist.github.com/conchurnavid/ac19c8e882f1835f0310

[LibRaw]

Thank you for the patch.

To be included in next Libraw 0.18 update

[LibRaw]

Unfortunately, this patch will broke 4-color raw processing.

To be reverted.

[mfvescovi]

Then you should re-open the issue, since it's not fixed yet.

[LibRaw]

This is different issue.

Patch (discussed above) fixes gcc-6 problems. These problems are fixed in current github branch, so issue is closed.

[mfvescovi]

Could you please point me to the patch fixing the GCC-6 FTBFS? It's considered a RC bug in Debian and LibRaw would be removed from testing/stretch suite due to this.
Thanks in advance.

[LibRaw]

eba7a66

This patch is already in LibRaw-master at github (this repo).
This patch will broke 4-color RAWs with VNG demosaic, but 99.9% of users will not notice that

[mfvescovi]

Perfect. Thanks a lot.
I already used the first draft of the patch, but it fixed the issue
partially. In fact, someone on the Debian BTS pointed this out. I'll fix
completely with this new one.
Cheers.

Il mer 27 lug 2016, 22:33 LibRaw LLC notifications@github.com ha scritto:

eba7a66
eba7a66

This patch is already in LibRaw-master at github (this repo).
This patch will broke 4-color RAWs with VNG demosaic, but 99.9% of users
will not notice that

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#56 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABj27v_xVjt2lc49GbHwtGy1Y-A8yWx5ks5qZ8CLgaJpZM4HIa6m
.

Matteo F. Vescovi

[lock042]

I think I am the 0.01% who noticed that :) (http://www.libraw.org/node/2214)
VNG interpolation crashes everytime with my software, on debian testing.

Has the bug been reported on debian ?

[LibRaw]

we'll issue new public patch that fixes gcc6 incompatibility (with working vng) today.

And, sure, we'll contact debian after that

[lock042]

Wonderful :)
Nice job and thank you.

[LibRaw]

Commited: 8a8723b

[LibRaw]

@mfvescovi please re-patch debian copy of libraw 0.17.2 , there are users already affected by old broken patch.

[mfvescovi]

@LibRaw Since "master" and "0.17-stable" branches are quite different, could you please provide a backport for it too, as commit there? Just to avoid any possible mistake in applying the wrong patch again and again.
Then, should I use d690068 as well?

[LibRaw]

d690068 removes one extra warning (not significant :)

[LibRaw]

0.17 branch: c3bf298

[mfvescovi]

@LibRaw With the new patch LibRaw is FTBFS on all little-endian, as you can see at https://buildd.debian.org/libraw
Any idea how to fix that too?

[LibRaw]

OK, let's replace type conversion with explicit value: 94ee55e

Tested on both 3-color and 4-color images, but only on intel CPU

[mfvescovi]

@LibRaw in fact this new change fails again, see http://debomatic-armel.debian.net/distribution#unstable/libraw/0.17.2-6/buildlog as an example. Same story for armhf, powerpc and ppc64el, which I've tested before replying here.

[LibRaw]

Sorry, this is different error. I thought this is the same vng_interpolate issue, but line 2491 is in kodak_radc_load_raw() and resulted from:
static const char src[] = {
....
1,0, 2,2, 2,-2,

Is char is unsigned by default in arm/etc architectures?

[mfvescovi]

As stated in https://wiki.debian.org/ArchitectureSpecificsMemo, all failing architectures have unsigned char.

[LibRaw]

this patch should help: 4075372

[mfvescovi]

@LibRaw much much better now: https://buildd.debian.org/libraw
Thanks a lot.
@lock042 could you please test if -6 revision fixes your issue? Thanks.

[lock042]

Hello.

OK, as soon as the -6 is in testing I'll test it.
Thank you.

[lock042]

I can confirm that the bug is fixed.

Thank you.