Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 compile fixes #10

Closed
wants to merge 3 commits into from
Closed

Win32 compile fixes #10

wants to merge 3 commits into from

Conversation

jmue
Copy link

@jmue jmue commented Aug 25, 2011

When building an external application against LibRaw I get following compiler warning with VS2010:

warning C4251: 'LibRaw_file_datastream::f' : class 'std::auto_ptr<_Ty>' needs to have dll-interface to be used by clients of class 'LibRaw_file_datastream'
1> with
1> [
1> _Ty=std::streambuf
1> ]

This patch fixes the warning.

Regards, Jens

@LibRaw
Copy link
Owner

LibRaw commented Aug 25, 2011

Could you please remove patch 5d926cb from pull request? I want to close the request by 'merge pull request' but 5d926cb is another story.

@jmue
Copy link
Author

jmue commented Aug 25, 2011

Argh, this 5d926cb patch is ugly. It is on my master branch and I reverted it with b6b68ea. (Please check https://github.com/jmue/LibRaw/blame/win32_compile_fixes/libraw/libraw_version.h ) But I could not get it out of my history with a 'git reset'. So three different options

  1. you fix it on your branch (fine for me)
  2. you take my ugly history or bring the three 3 commits in a single commit
  3. I trash my git clone, fork again and fix it again

Sorry!

@LibRaw
Copy link
Owner

LibRaw commented Aug 25, 2011

I've fixed the my master branch by hand and pushed to GitHub.

Thanks for fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants