You should do a WSACleanup for each WSAStartup

[danielgindi]

That's by definition of Winsock...

[bk138]

patches welcome, as always ;-)

[dscho]

You should do a WSACleanup for each WSAStartup

It might be a good idea to spend a little bit of effort to make a bug report sound different from the equivalent of throwing left-over bones to a dog. Nobody likes to be treated like that dog, and I, for one, am no exception.

An excellent way to make up for this unfortunate impression would be to provide the patches @bk138 asked for, indeed.

[danielgindi]

Of course, as soon as I have the time I will make a patch.
I wrote that Issue with the understanding that the people who wrote this library, and make a call to WSAStartup, read the documentation about that function and noticed that there's a WSACleanup.
It shouldn't be too hard to understand this from the title of the Issue.
Unless, of course, if you are not really familiar with the Windows platform, or Winsock, and that's a whole other story.

[bk138]

Windows was not really the premier platform the lib was developed on/for, so the implementation is not as good as for POSIX. Thanks for your patches!

[dscho]

@bk138 I actually closed this with the intention of waiting for @danielgindi's pull request...

[bk138]

@dscho Sry, my rationale was that the issue is still existing anyway. For the record, I'd keep it open unless it's fixed.

[bk138]

• https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsastartup
• https://stackoverflow.com/questions/1869689/is-it-possible-to-tell-if-wsastartup-has-been-called-in-a-process

[bk138]

libvncserver/libvncserver/main.c

Line 1114 in fc4d160

void rfbInitServer(rfbScreenInfoPtr screen)

[bk138]

libvncserver/libvncclient/sockets.c

Line 331 in d9ca839

static int initSockets() {