Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultSupportedMessagesUltraVNC() and DefaultSupportedMessagesTightVNC() are never called #505

Closed
badda71 opened this issue Mar 15, 2022 · 1 comment · Fixed by #506
Closed
Labels

Comments

@badda71
Copy link
Contributor

badda71 commented Mar 15, 2022

In file rfbproto.c, function InitialiseRFBConnection() libvncserver checks the RFB version sent by the server and calls DefaultSupportedMessagesUltraVNC() or DefaultSupportedMessagesTightVNC() depending on the received RFB version (3.4, 3.6, 3.14 or 3.16 for UltraVNC, 3.5 for TightVNC). However, the recent versions of the servers all report RFB version 3.8, so the server-specific capabilities are never set. This means, for example, that server-side scaling does not work anymore (because the capability is set in DefaultSupportedMessagesUltraVNC).
We need a new way of identifiying the servers - unsing the RFB version does not work anymore ...

@badda71 badda71 added the bug label Mar 15, 2022
@badda71
Copy link
Contributor Author

badda71 commented Mar 15, 2022

Added pull request #506 to fix this issue.
With this, UltraVNC and TightVNC servers are not recognized by the RFB version, but by their specific security types (rfbUltra and rfbTight).

bk138 pushed a commit that referenced this issue Mar 16, 2022
...in addition to using the legacy way of checking RFB protocol versions.

Closes #505
@bk138 bk138 added this to the Release 0.9.14 milestone Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants