CMakeLists.txt: use pkgconfig to find openssl #319
Conversation
find_package(openssl) fails to find openssl dependencies such as -lz so use pkgconfig to fix static build if pkg-config is found, otherwise fallback to existing mechanism Fixes: - http://autobuild.buildroot.org/results/c3f75480cb4b8b042cdf6a34cc5568ea13e51342 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Mh shouldn't this be a pull request to CMake? This one is a mere mitigation... |
|
This should be fixed in CMake. If you have convincing arguments why we should mitigate a CMake bug in our build system, please re-open :-) |
|
My main argument is that static building of libvncserver was working on previous versions because the build system was autotools. IMHO, cmake is just bad at static building because it doesn't use pkgconfig file to retrieve library dependencies. But even if this bug was fixed into a newer cmake's version, it will be broken on all previous versions. But that's your right to refuse to mitigate a cmake bug. On my side, I will just disable libvncserver package for all buildroot static builds. |
Disable libvncserver for static builds and drop second patch following upstream feedback on patch fixing openssl issue: LibVNC/libvncserver#319 This will also fix build failure when building statically with libgcrypt Don't update x11vnc, the reverse dependency of libvncserver, because BR2_PACKAGE_XORG7 already depends on !BR2_STATIC_LIBS Fixes: - http://autobuild.buildroot.org/results/8d7b109d085e3931a874c4fb99f465789485565a Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
|
For the record, this issue was already reported to cmake two years ago: https://gitlab.kitware.com/cmake/cmake/issues/16885. |
|
Thanks for pointing this out, I was about to report an upstream bug with them |
Disable libvncserver for static builds and drop second patch following upstream feedback on patch fixing openssl issue: LibVNC/libvncserver#319 This will also fix build failure when building statically with libgcrypt Don't update x11vnc, the reverse dependency of libvncserver, because BR2_PACKAGE_XORG7 already depends on !BR2_STATIC_LIBS Fixes: - http://autobuild.buildroot.org/results/8d7b109d085e3931a874c4fb99f465789485565a Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> (cherry picked from commit 726dcc6) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
find_package(openssl) fails to find openssl dependencies such as -lz so
use pkgconfig to fix static build if pkg-config is found, otherwise
fallback to existing mechanism
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com