Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvncclient: Add qemu extended key event #453

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

any1
Copy link
Contributor

@any1 any1 commented Nov 30, 2020

This adds qemu extended key events to libvncclient, which greatly simplifies key event handling and improves robustness over the standard method.

An example of the new function call, SendExtendedKeyEvent, being used can be found here: https://github.com/any1/wlvncc/blob/qemu-extended-key-event/src/vnc.c#L215-L226

This functionality was tested using https://github.com/any1/wayvnc/tree/qemu-kb-ext & https://github.com/any1/neatvnc/tree/qemu-kb-ext.

Copy link
Member

@bk138 bk138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! Thank you! One minor change request.

libvncclient/rfbproto.c Outdated Show resolved Hide resolved
@any1
Copy link
Contributor Author

any1 commented Dec 2, 2020

Changes made per request.

libvncclient/rfbproto.c Outdated Show resolved Hide resolved
This function sends Qemu extended key events to servers that support
such messages. It returns FALSE if the event is not supported.
@bk138 bk138 merged commit c82b3ab into LibVNC:master Dec 2, 2020
@bk138 bk138 modified the milestones: Release 1.0.0, Release 0.9.14 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants