-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libvncclient extended clipboard pseudo-encoding support #545
Conversation
Thanks for the contribution! Please document in the code
|
extended clipboard support |
extended clipboard support need zlib. It is possible to use libvncclient without zlib? Or please help me to protect the code by some Macro. |
Yes, I added some hints for you in the review comments. Thanks for the contribution, I think with some more work we can get this in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wuhanck I now understoof your point about the config flag. Only two minor things missing AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, two more questions. Thanks for keeping up with this PR!
@wuhanck I think some more work is required:
|
@bk138. clipboardCap is not a bool. It is a cap bitset....Maybe current name is descriptive. useclipboardcap is confusing. if we want to ignore and fallback to old sytle latin-1, we need the logic after 80aacdc. |
@bk138 it is simple and solid to just block old path and let the upper layer to setup corret conf. |
@bk138 I test sdlvncviewer with tigervnc standalone server. |
@wuhanck I now understood your point about
|
OK. I refine the patch. Refine the patch for zlib check. |
Please note that according to rfbproto, it is still allowed to use a positive value of the length for the clipboard message (i.e., still use Latin-1) even if the Extended Clipboard Pseudo Encoding is enabled. So I would suggest handling this case. |
I know server can do this. It is designed to let it improve in future. The limitation is not global. It is when a server announce clipboardcap on a session, then it use old way to send on this session. as you known, we still lack lot of features which extended clipboard pseudo encoding support.... |
@wuhanck I saw you closed this PR and emptied the branch. I deem this to be a bit sad, as the contribution was almost ready to go in. I can understand that code review and rework can be frustrating at times, but id needs to be done for the sake of quality of the product. As this is all about open-source and voluntary contributions, your decision is OK with me. I just want to state what I deem mergable (and the PR was close to this TBH):
So 3 of 4 ticked in my opinion. |
Sorry, I am clean repo from github.com…
I will restore and reopen a pull request.
Sorry about that. Please wait. I am working on that now.
从 Windows 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>发送
发件人: Christian ***@***.***>
发送时间: 2023年1月24日 22:31
收件人: ***@***.***>
抄送: ***@***.***>; ***@***.***>
主题: Re: [LibVNC/libvncserver] add libvncclient extended clipboard pseudo-encoding support (PR #545)
@wuhanck<https://github.com/wuhanck> I saw you closed this PR and emptied the branch. I deem this to be a bit sad, as the contribution was almost ready to go in. I can understand that code review and rework can be frustrating at times, but id needs to be done for the sake of quality of the product. As this is all about open-source and voluntary contributions, your decision is OK with me.
I just want to state what I deem mergable (and the PR was close to this TBH):
* ok to only implement a subset of functionality (in this case only text) ✅
* good-enough code quality ✅
* needs to work with other implementations ✅
* needs to work within the project itself (i.e. a libvncclient talking to libvncserver) ⛔
So 3 of 4 ticked in my opinion.
—
Reply to this email directly, view it on GitHub<#545 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQSUC77HWKTK6W5OI2VQNTWT7RSVANCNFSM6AAAAAATT4TVXI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I reopen the pull request in a new branch.
I add support for fallback for some guy seems need it.
Libvncserver don’t check Z_STREAM_END,so I add extra byte to make it happy.
It would harm others as far as I can see.
And I found
In the master, after commit f135856, some commit break things.
Maybe bug or api broken, I don’t know.
Please recheck them.
从 Windows 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>发送
发件人: Christian ***@***.***>
发送时间: 2023年1月24日 22:31
收件人: ***@***.***>
抄送: ***@***.***>; ***@***.***>
主题: Re: [LibVNC/libvncserver] add libvncclient extended clipboard pseudo-encoding support (PR #545)
@wuhanck<https://github.com/wuhanck> I saw you closed this PR and emptied the branch. I deem this to be a bit sad, as the contribution was almost ready to go in. I can understand that code review and rework can be frustrating at times, but id needs to be done for the sake of quality of the product. As this is all about open-source and voluntary contributions, your decision is OK with me.
I just want to state what I deem mergable (and the PR was close to this TBH):
* ok to only implement a subset of functionality (in this case only text) ✅
* good-enough code quality ✅
* needs to work with other implementations ✅
* needs to work within the project itself (i.e. a libvncclient talking to libvncserver) ⛔
So 3 of 4 ticked in my opinion.
—
Reply to this email directly, view it on GitHub<#545 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQSUC77HWKTK6W5OI2VQNTWT7RSVANCNFSM6AAAAAATT4TVXI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
从 Windows 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>发送
发件人: Christian ***@***.***>
发送时间: 2023年1月24日 22:31
收件人: ***@***.***>
抄送: ***@***.***>; ***@***.***>
主题: Re: [LibVNC/libvncserver] add libvncclient extended clipboard pseudo-encoding support (PR #545)
@wuhanck<https://github.com/wuhanck> I saw you closed this PR and emptied the branch. I deem this to be a bit sad, as the contribution was almost ready to go in. I can understand that code review and rework can be frustrating at times, but id needs to be done for the sake of quality of the product. As this is all about open-source and voluntary contributions, your decision is OK with me.
I just want to state what I deem mergable (and the PR was close to this TBH):
* ok to only implement a subset of functionality (in this case only text) ✅
* good-enough code quality ✅
* needs to work with other implementations ✅
* needs to work within the project itself (i.e. a libvncclient talking to libvncserver) ⛔
So 3 of 4 ticked in my opinion.
—
Reply to this email directly, view it on GitHub<#545 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQSUC77HWKTK6W5OI2VQNTWT7RSVANCNFSM6AAAAAATT4TVXI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
add libvncclient support for notify and text only.
although it is not full support, it is working for utf-8 clipboard.