Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler detection when using --without-{crypt,crypto,ssl} #28

Merged
merged 1 commit into from Oct 12, 2016
Merged

Fix compiler detection when using --without-{crypt,crypto,ssl} #28

merged 1 commit into from Oct 12, 2016

Conversation

kempniu
Copy link
Contributor

@kempniu kempniu commented Oct 12, 2016

As the author of #13 honestly admitted, moving around parts of configure.ac to fix its horrors is not the best solution. Specifically, the change introduced by #13 causes compilation to fail when --without-crypto and/or --without-ssl is used.

The root problem with configure.ac is that if the combination of configure switches used does not cause at least one branch with AC_CHECK_LIB to be evaluated then the C compiler is never detected.

The simplest way to fix this appears to be to explicitly look for a working C compiler before doing anything else and this is what this pull request attempts.

DISCLAIMER: I am no Autotools expert. This just happened to work for me.

@bk138 bk138 merged commit 36a46c7 into LibVNC:master Oct 12, 2016
@bk138
Copy link
Member

bk138 commented Oct 12, 2016

At least that'll do no harm ;-) Thanks!

@kempniu kempniu deleted the fix-compiler-detection branch October 13, 2016 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants