Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tentative] Add tests/assertions for allowed x_specs fields, implement x_specs['user'] #269

Closed
1 of 3 tasks
jlnav opened this issue Oct 29, 2019 · 2 comments
Closed
1 of 3 tasks
Assignees
Projects

Comments

@jlnav
Copy link
Member

jlnav commented Oct 29, 2019

Related to #266

'x' refers to either 'sim', 'gen', or 'alloc'.

Considering what data is necessarily passed to user functions, how to best differentiate between libE-reserved fields and user-defined-fields, and how to support sim_f/gen_f's with differing output data-types, we seem to now be leaning towards option 2 from #266 .

This will require several updates:

  • Implement checks and assertions that libE/user fields are defined in their proper structures. For example, keep user-defined sim fields in sim_specs['user']

  • Construct tests for these assertions, also update formatting for other tests.

  • Update documentation, including examples and tutorials

Feel free to update this issue and/or offer suggestions for proceeding.

@jmlarson1
Copy link
Member

@jlnav I think this is somewhat addressed by PR #271, except the update of documentation. I'm not sure what other assertions we might need, other than checking that x_spec keys match a pre-defined list. (After compiling that list in libE.py, I think we should consider moving some things to libE_specs, but that is later.)

@jmlarson1 jmlarson1 moved this from To Do to In progress in libE Kanban Oct 31, 2019
@jlnav jlnav moved this from In progress to In review/testing in libE Kanban Nov 11, 2019
@shuds13 shuds13 mentioned this issue Nov 12, 2019
13 tasks
@jlnav
Copy link
Member Author

jlnav commented Nov 15, 2019

Presumably closed by #271

@jlnav jlnav closed this as completed Nov 15, 2019
@shuds13 shuds13 moved this from In review/testing to Done in libE Kanban Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants