Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/structured specs #271

Merged
merged 14 commits into from Oct 31, 2019
Merged

Feature/structured specs #271

merged 14 commits into from Oct 31, 2019

Conversation

jmlarson1
Copy link
Member

I have implemented the usage of 'user' for the unit/regression tests and example sim/gen funcs.

I plan on moving some of the contents of sim_specs and gen_specs to libE_specs, but I will do that in a different PR

@jmlarson1 jmlarson1 mentioned this pull request Oct 31, 2019
Closed
3 tasks
@jmlarson1
Copy link
Member Author

jmlarson1 commented Oct 31, 2019 •
edited

This PR is in response to Issue #269 and #266

@coveralls
Copy link
Collaborator

coveralls commented Oct 31, 2019 •
edited

Coverage Status

Coverage decreased (-1.2%) to 93.557% when pulling 679043d on feature/structured_specs into 417f524 on develop.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-1.3%) to 93.414% when pulling 559f795 on feature/structured_specs into 417f524 on develop.

shuds13
shuds13 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to do it!

jlnav
jlnav approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@jlnav jlnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I'll submit a separate pull-request for the flaky balsam test.

@jmlarson1 jmlarson1 merged commit 5eff5c5 into develop Oct 31, 2019
@jmlarson1 jmlarson1 deleted the feature/structured_specs branch October 31, 2019 15:53
@jlnav jlnav mentioned this pull request Nov 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuds13 shuds13 shuds13 approved these changes

@jlnav jlnav jlnav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmlarson1 @coveralls @shuds13 @jlnav