Refactoring the Ensemble class somewhat #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moved into api.py for Ensemble class. Ensemble class treats/casts specs parameters as classes
|
rename api.py to ensemble.py |
shuds13
approved these changes
May 16, 2023
|
Approve with change .api. to .ensemble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also starting to de-emphasize the libE function in favor of
Ensemble.run()Moving/reorganizing some running-libE content into api.py
Also making Ensemble a normal class. It being a dataclass made autoclass'ing it somewhat ugly.
We're also assuming from here on that specs we're passing into the Ensemble class will be cast to their class counterparts.