Refactor/oo more tests #1051
Merged
Refactor/oo more tests #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmlarson1
approved these changes
Aug 22, 2023
shuds13
reviewed
Aug 23, 2023
| out=[("num_procs", int), ("num_gpus", int), ("x", float, 2)], | ||
| user={ | ||
| "initial_batch_size": gpu_test.nworkers - 1, | ||
| "max_procs": (gpu_test.nworkers - 1) // 2, # Any sim created can req. 1 worker up to max |
There was a problem hiding this comment.
This test needs updating following #1058, I can do this if it helps.
Update this line and add second loop.
There was a problem hiding this comment.
Whoops - I meant test_GPU_variable_resources_multi_task.py, But I think this line should be changed here also.
|
I think adding the parse_args option to ensemble would be good, as otherwise, the knowing of nworkers is a bit magical. |
shuds13
reviewed
Aug 23, 2023
| assert np.array_equal(H0["x"], H["x"]) | ||
| assert np.all(H["sim_ended"]) | ||
| sampling = Ensemble() | ||
| sampling.H0 = H0 |
There was a problem hiding this comment.
I wonder if we should stick to function calls, matter of style. Or should we make this an option to Ensemble()?
There was a problem hiding this comment.
Both ways of setting H0 (and other attributes) are valid:
sampling = Ensemble(H0=H0)
or:
sampling = Ensemble()
sampling.H0 = H0
shuds13
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.