Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad calc_dirs with zeros #1052

Merged
merged 9 commits into from
Aug 22, 2023
Merged

Pad calc_dirs with zeros #1052

merged 9 commits into from
Aug 22, 2023

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Aug 7, 2023

Funnily enough to do this, we have to send exit_criteria to the workers.

@jlnav jlnav requested a review from shuds13 August 7, 2023 16:43
@jlnav jlnav mentioned this pull request Aug 7, 2023
34 tasks
@shuds13
Copy link
Member

shuds13 commented Aug 7, 2023

My understanding of this was something like:

libE_specs["simid_field_width"] = 5.

ensemble/
      sim00001
      sim00002
      sim00003`

If an H0 is supplied, another sim_max calculations will be done, so it could produce more directories. Also, may end based on a value, rather than sim/gen_max.

Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a unit test.

@shuds13
Copy link
Member

shuds13 commented Aug 10, 2023

and update the top comment here.

@shuds13
Copy link
Member

shuds13 commented Aug 10, 2023

I ran

python test_GPU_variable_resources.py --comms local --nworkers 4

and it gave me a width of four, without adding the option.

@jlnav jlnav requested a review from shuds13 August 14, 2023 14:43
@shuds13
Copy link
Member

shuds13 commented Aug 17, 2023

This works well, and adds digits on overflow as needed.

I think we just need to check we agree on the option name "calc_dir_id_width".

@jmlarson1 jmlarson1 merged commit ae4f101 into develop Aug 22, 2023
15 checks passed
@jmlarson1 jmlarson1 deleted the feature/calc_dir_zpad branch August 22, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants