-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pad calc_dirs with zeros #1052
Pad calc_dirs with zeros #1052
Conversation
My understanding of this was something like: libE_specs["simid_field_width"] = 5.
If an H0 is supplied, another sim_max calculations will be done, so it could produce more directories. Also, may end based on a value, rather than sim/gen_max. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a unit test.
and update the top comment here. |
I ran python test_GPU_variable_resources.py --comms local --nworkers 4 and it gave me a width of four, without adding the option. |
This works well, and adds digits on overflow as needed. I think we just need to check we agree on the option name "calc_dir_id_width". |
Funnily enough to do this, we have to send exit_criteria to the workers.