Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap defaults to False of kill_canceled_sims and safe_mode #1053

Merged
merged 3 commits into from
Aug 9, 2023
Merged

swap defaults to False of kill_canceled_sims and safe_mode #1053

merged 3 commits into from
Aug 9, 2023

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Aug 7, 2023

No description provided.

@jlnav jlnav requested review from jmlarson1 and shuds13 August 7, 2023 17:16
@jlnav jlnav mentioned this pull request Aug 7, 2023
Closed
34 tasks
shuds13
shuds13 reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to try optimizing kill_cancelled_sims. Then we can discuss whether to make the breaking change of defaulting to False. I'm hoping it can stay True.

shuds13
shuds13 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash merge.

@jlnav jlnav merged commit 95b7b11 into develop Aug 9, 2023
12 of 14 checks passed
@jlnav jlnav deleted the refactor/default_settings_adjust_performance branch August 9, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuds13 shuds13 shuds13 approved these changes

@jmlarson1 jmlarson1 Awaiting requested review from jmlarson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlnav @shuds13