Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpi_runner_type submit option to executor #1054

Merged
merged 9 commits into from
Sep 1, 2023

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Aug 7, 2023

The supplied MPI runner will be used for this submit only.

This is useful in combination with the environment script option, when a different MPI runner may be needed for a particular submit.

The option can be given as a string specifying the MPI runner (e.g. "mpich", "openmpi", "srun", "jsrun", "aprun"), or as a dictionary with the same options as custom_info when setting up the executor e.g : {"mpi_runner": "openmpi", "runner_name": "myrunner"}

Provides support for optimas-org/optimas#108

  • Add functionality test
  • Discuss/agree name of argument (currently mpi_runner_type). Could be mpi_runner, env_mpi, mpi_config etc...
  • Check if this branch MPIExecutor works standalone @jlnav

Another change is that when using an environment script, the generated script is logged to ensemble.log rather than the mpirun line itself (which is in the script). This could be either way - any feedback welcome.

Ideally, the mpi_runner_type option would match custom_info in executor init function in name and accepted input.

@shuds13 shuds13 self-assigned this Aug 7, 2023
@shuds13 shuds13 added this to In progress in libE Kanban Aug 7, 2023
@shuds13 shuds13 marked this pull request as ready for review August 7, 2023 22:20
@jlnav
Copy link
Member

jlnav commented Aug 18, 2023

Tentative consensus for "mpi_runner"

@jlnav
Copy link
Member

jlnav commented Aug 22, 2023

second tentative consensus for "mpi_runner_type" ?

@jmlarson1 jmlarson1 self-requested a review August 22, 2023 20:57
@shuds13 shuds13 mentioned this pull request Aug 31, 2023
34 tasks
@shuds13
Copy link
Member Author

shuds13 commented Sep 1, 2023

Think I'm going to keep mpi_runner_type

@shuds13 shuds13 merged commit 1de569c into develop Sep 1, 2023
13 of 16 checks passed
@shuds13 shuds13 moved this from In progress to In review/testing in libE Kanban Sep 1, 2023
@jmlarson1 jmlarson1 deleted the feature/mpirunner_submit_option branch September 21, 2023 13:51
@shuds13 shuds13 moved this from In review/testing to Done in libE Kanban Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants