Refactor/localopt specific imports #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, removes customizer from test...nlopt
…. only needed for petsc
…ary line in other petsc tests
jmlarson1
reviewed
Aug 21, 2023
jmlarson1
approved these changes
Aug 21, 2023
|
I don't see that the breaking change is necessary. The old rc options would still work - just putting imports in functions and removing the defaults. Either way, we also need a test, and to document when a global import should not be used. I have a test that uses OpenMPI with the executor, which I can add, so this can be run in the CI. Also, mpi4py is working on my laptop, with or without global import, is it failing for you? @jlnav |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified locally works with openmpi