Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default rsets assigned to -1 #1290

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Default rsets assigned to -1 #1290

merged 2 commits into from
Apr 22, 2024

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Apr 22, 2024

rsets["assigned"] must to default to -1, not zero, now we can assign resources to worker 0.

@shuds13 shuds13 added the Bugfix label Apr 22, 2024
@shuds13 shuds13 self-assigned this Apr 22, 2024
@shuds13 shuds13 added this to In progress in libE Kanban Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.87%. Comparing base (0d99592) to head (7001440).
Report is 46 commits behind head on develop.

Files Patch % Lines
libensemble/resources/worker_resources.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1290      +/-   ##
===========================================
- Coverage    94.38%   86.87%   -7.52%     
===========================================
  Files           90       90              
  Lines         8262     8212      -50     
  Branches      1481     1456      -25     
===========================================
- Hits          7798     7134     -664     
- Misses         276      888     +612     
- Partials       188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuds13 shuds13 requested review from jmlarson1 and jlnav April 22, 2024 17:01
@shuds13 shuds13 merged commit d4ad5ea into develop Apr 22, 2024
22 of 32 checks passed
@jmlarson1 jmlarson1 deleted the bugfix/gen0_resources branch April 23, 2024 20:21
@shuds13 shuds13 mentioned this pull request Apr 25, 2024
19 tasks
@shuds13 shuds13 moved this from In progress to In review/testing in libE Kanban Apr 25, 2024
@shuds13 shuds13 moved this from In review/testing to Done in libE Kanban May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants