Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default alloc_specs from libE() definition to alloc_funcs.defaults #342

Merged
merged 4 commits into from Jan 27, 2020

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Jan 27, 2020

Possibly addresses #325

This simple approach tries to address the concerns laid out in the above issue where the default alloc_specs were defined in the libE function definition.

This moves the default alloc_specs to /alloc_funcs. They are imported in libE.py, and can be imported and adjusted within calling scripts through:

from libensemble.alloc_funcs import defaults
alloc_specs = defaults.alloc_specs

Potentially, other default settings throughout typical libE projects can be imported and adjusted in this manner. Or, the default alloc_specs could be returned by parse_args().

Copy link
Member

@jmlarson1 jmlarson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2020

Pull Request Test Coverage Report for Build 2679

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 94.646%

Totals Coverage Status
Change from base Build 2673: -0.03%
Covered Lines: 3997
Relevant Lines: 4185

💛 - Coveralls

Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happy to go with this. Can you make sure its covered in docs/ - esp. how the user can import the defaults and modify.

@jlnav jlnav merged commit 8165094 into develop Jan 27, 2020
@jlnav jlnav deleted the feature/alloc_default_adjust branch January 27, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants