Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental/aposmm rc #426

Merged
merged 20 commits into from
Apr 17, 2020
Merged

Experimental/aposmm rc #426

merged 20 commits into from
Apr 17, 2020

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Apr 14, 2020

Some fixes plus extend to aposmm as well as persistent_aposmm.

@shuds13 shuds13 requested a review from jmlarson1 April 14, 2020 21:16
@coveralls
Copy link
Collaborator

coveralls commented Apr 14, 2020

Pull Request Test Coverage Report for Build 3251

  • 13 of 20 (65.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 95.438%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libensemble/gen_funcs/persistent_aposmm.py 3 5 60.0%
libensemble/gen_funcs/aposmm.py 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
libensemble/resources/node_resources.py 1 80.0%
libensemble/gen_funcs/persistent_aposmm.py 3 96.06%
Totals Coverage Status
Change from base Build 3241: -0.2%
Covered Lines: 4217
Relevant Lines: 4375

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Apr 14, 2020

Pull Request Test Coverage Report for Build 3251

  • 13 of 20 (65.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.438%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libensemble/gen_funcs/persistent_aposmm.py 3 5 60.0%
libensemble/gen_funcs/aposmm.py 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
libensemble/gen_funcs/persistent_aposmm.py 3 96.2%
Totals Coverage Status
Change from base Build 3241: -0.2%
Covered Lines: 4217
Relevant Lines: 4375

💛 - Coveralls

@jmlarson1
Copy link
Member

@shuds13

  1. I'm not sure which side of the conflicts to take for scaling_tests/warpx files. Do you?
  2. Does this approach not work if the local optimizer in persistent_aposmm is changed between two libE calls in the same script? (I couldn't get test_persistent_aposmm_periodic.py to work with this new import approach.)

@shuds13
Copy link
Member Author

shuds13 commented Apr 15, 2020

I'll take a look and resolve.

@shuds13 shuds13 merged commit 1377972 into experimental/warpX Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants