Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/more gens #428

Merged
merged 30 commits into from
Apr 17, 2020
Merged

Docs/more gens #428

merged 30 commits into from
Apr 17, 2020

Conversation

jmlarson1
Copy link
Member

No description provided.

jlnav and others added 24 commits March 27, 2020 15:24
…ple_size

Asserting that there are enough starting points for APOSMM
@jmlarson1 jmlarson1 requested a review from shuds13 April 16, 2020 19:02
@coveralls
Copy link
Collaborator

coveralls commented Apr 17, 2020

Pull Request Test Coverage Report for Build 3312

  • 275 of 280 (98.21%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 95.854%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libensemble/executors/mpi_executor.py 1 2 50.0%
libensemble/gen_funcs/aposmm_localopt_support.py 260 262 99.24%
libensemble/gen_funcs/persistent_deap_nsga2.py 1 3 33.33%
Totals Coverage Status
Change from base Build 3296: 0.01%
Covered Lines: 4254
Relevant Lines: 4398

💛 - Coveralls

@shuds13
Copy link
Member

shuds13 commented Apr 17, 2020

The persistent_aposmm docs does not include the main aposmm function (its not in _all_ ).

Also, just wondering do we have a section on the available optimizers anywhere?

@shuds13
Copy link
Member

shuds13 commented Apr 17, 2020

I want to pull this in now and I will make sure we consolidate develop. I can pull into aposmm_rc and then pull that again into warpx and then pull that into develop.

I think we may then want to do a bit more work on this. My main issue is whether this is supposed to present a API to the user of the gens, or just example gens. Also for the APOSMM user, we want them to have the information they need for setting up sim/gen specs and what optimizer options, but not sure we want to provide internal APOSMM routines.

Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets pull this into aposmm_rc branch now, and I will get everything into develop. Then decide if we need more work on the gen docs.

@jmlarson1
Copy link
Member Author

Sounds good

@jmlarson1 jmlarson1 merged commit 5fd84e5 into experimental/aposmm_rc Apr 17, 2020
@jmlarson1 jmlarson1 deleted the docs/more_gens branch April 17, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants