-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/more gens #428
Docs/more gens #428
Conversation
…in calling script
…ple_size Asserting that there are enough starting points for APOSMM
fix some broken or subpar links
Forces exception tests
…tion value is duplicated
Feature/default aposmm nworkers
(cherry picked from commit 5bbddf0)
Pull Request Test Coverage Report for Build 3312
💛 - Coveralls |
The persistent_aposmm docs does not include the main aposmm function (its not in _all_ ). Also, just wondering do we have a section on the available optimizers anywhere? |
I want to pull this in now and I will make sure we consolidate develop. I can pull into aposmm_rc and then pull that again into warpx and then pull that into develop. I think we may then want to do a bit more work on this. My main issue is whether this is supposed to present a API to the user of the gens, or just example gens. Also for the APOSMM user, we want them to have the information they need for setting up sim/gen specs and what optimizer options, but not sure we want to provide internal APOSMM routines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets pull this into aposmm_rc branch now, and I will get everything into develop. Then decide if we need more work on the gen docs.
Sounds good |
No description provided.