Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forces - Functions to test ensemble_dir, exception logging #441

Merged
merged 3 commits into from May 7, 2020
Merged

Forces - Functions to test ensemble_dir, exception logging #441

merged 3 commits into from May 7, 2020

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented May 5, 2020 •
edited

Adds forces_support.py file to Forces test, containing functions to test exception logging (when relevant) and structure/output of ensemble directory.

jlnav added 2 commits May 5, 2020 11:43
@jlnav
Adds forces support file with functions to check ensemble dir, output…
d85c48c 
… files. functions added to conclusion of run_libe_forces
@jlnav
flake8
b3c4118
@coveralls
Copy link
Collaborator

coveralls commented May 5, 2020 •
edited

Pull Request Test Coverage Report for Build 3435

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 95.763%
Files with Coverage Reduction New Missed Lines %
libensemble/gen_funcs/aposmm_localopt_support.py 1 96.08%
libensemble/resources/node_resources.py 1 79.2%
Totals Coverage Status
Change from base Build 3405: -0.2%
Covered Lines: 4280
Relevant Lines: 4421
💛 - Coveralls

@jlnav jlnav requested a review from shuds13 May 5, 2020 20:41
@shuds13
Copy link
Member

shuds13 commented May 6, 2020 •
edited

Are you updating the forces.c in here also?

With the print hostname part.

@jlnav jlnav merged commit 0a65b65 into develop May 7, 2020
@jlnav jlnav deleted the testing/forces_output_tests branch May 7, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuds13 shuds13 shuds13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlnav @coveralls @shuds13