Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to comply with flake8 3.8.0 #453

Merged
merged 1 commit into from May 12, 2020
Merged

Changes to comply with flake8 3.8.0 #453

merged 1 commit into from May 12, 2020

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented May 12, 2020

No description provided.

@shuds13 shuds13 requested review from jmlarson1 and jlnav May 12, 2020 03:01
@coveralls
Copy link
Collaborator

coveralls commented May 12, 2020 •
edited

Pull Request Test Coverage Report for Build 3515

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 96.237%
Totals Coverage Status
Change from base Build 3501: -0.05%
Covered Lines: 4454
Relevant Lines: 4587
💛 - Coveralls

@jmlarson1
Copy link
Member

I am confused as to why the flake8-3.7.9 that I was running locally allowed the errors
E741 ambiguous variable name 'O'.

But I'm happy this was easy to fix.

@jmlarson1 jmlarson1 merged commit ddc7024 into develop May 12, 2020
@jmlarson1 jmlarson1 deleted the feature/comply_flake8_3.8 branch May 12, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmlarson1 jmlarson1 jmlarson1 approved these changes

@jlnav jlnav Awaiting requested review from jlnav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuds13 @coveralls @jmlarson1