Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tentatively rename allow_oversubscribe, document #665

Merged
merged 3 commits into from Sep 22, 2021

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Sep 21, 2021

No description provided.

@jlnav jlnav requested a review from shuds13 September 21, 2021 19:58
@coveralls
Copy link
Collaborator

coveralls commented Sep 22, 2021

Pull Request Test Coverage Report for Build 1261935208

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 60 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.7%) to 92.542%

Files with Coverage Reduction New Missed Lines %
libensemble/alloc_funcs/give_pregenerated_work.py 1 93.33%
libensemble/alloc_funcs/give_sim_work_first.py 1 95.0%
libensemble/alloc_funcs/start_only_persistent.py 1 97.06%
libensemble/resources/mpi_resources.py 1 76.87%
libensemble/tools/alloc_support.py 1 94.52%
libensemble/alloc_funcs/inverse_bayes_allocf.py 2 92.31%
libensemble/alloc_funcs/only_one_gen_alloc.py 2 90.0%
libensemble/alloc_funcs/start_fd_persistent.py 2 93.44%
libensemble/alloc_funcs/start_persistent_consensus.py 2 93.68%
libensemble/alloc_funcs/start_persistent_local_opt_gens.py 2 95.24%
Totals Coverage Status
Change from base Build 1259005701: 0.7%
Covered Lines: 6155
Relevant Lines: 6576

💛 - Coveralls

Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A grep shows couple of mentions of allow_oversubscribe still in docs

@jlnav jlnav marked this pull request as ready for review September 22, 2021 15:49
@shuds13 shuds13 merged commit 7d86032 into feature/adaptive_workers Sep 22, 2021
@jlnav jlnav deleted the feature/move_allow_oversubscribe branch September 22, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants