-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU detection and auto-assign GPUs #983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for known systems (Just Summit so far) Then if needed look at environment Then if needed detect (remote or local)
Default GPU setting for each MPI runner (or CUDA_VISIBLE_DEVICES). mpi_executor can access platform info (obtained via env variable LIBE_PLATFORM)
Add test test_GPU_variable_resources.py Add sim_f six_hump_camel_GPU_variable_resources (checks settings) Store environment var settings in task Adds gpu setting type GPU_SET_CLI_GPT (gpus per task). Default for jsrun. Adds check_gpu_setting function in tools
Mocks runs for each MPI runner and checks GPU settings.
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
reviewed
Apr 27, 2023
jlnav
approved these changes
Apr 28, 2023
jmlarson1
approved these changes
Apr 28, 2023
…ensemble into feature/auto_assign_gpus
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Re-opened after merge from develop (was #980) - now going straight to develop, superseding #928
Extension to gpu_detect branch. Executor options to set CPUs and GPUs to slots using either the method supplied in configuration or determined by the detected environment. This simplifies sim functions and makes them more portable.
There are different ways this could be specified in the arguments to submit. Current approach uses
auto_assign_gpus
and optionallymatch_procs_to_gpus
, whereauto_assign_gpus
will use all GPUs assigned to current worker. Method for setting GPUs determined by either MPI runner, specified platform (via env variable LIBE_PLATFORM), or default.Checklists
Before merging:
Sunspot - currently need to set GPU/worker (and MPI rank) affinity via a bash script. Sep. branch for this.