Refactor / replace os.path with pathlib in many places #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s fixing that validator again. need to avoid passing through Path('.')
shuds13
reviewed
May 1, 2023
shuds13
reviewed
May 1, 2023
shuds13
reviewed
May 1, 2023
| @@ -56,7 +57,8 @@ def test_location_stack(): | |||
|
|
|||
| # Push registered location (we should move | |||
| s.push_loc(0) | |||
| assert s.stack == [None, start_dir], "Directory stack is incorrect." "Wanted [None, {}], got {}.".format( | |||
| stack = s.stack | |||
| assert stack == [None, Path(start_dir)], "Directory stack is incorrect." "Wanted [None, {}], got {}.".format( | |||
There was a problem hiding this comment.
Isn't Path already applied? Is this passing?
There was a problem hiding this comment.
Ok, it passes, but I dont think its needed
There was a problem hiding this comment.
Most of this infrastructure is from David, and I just adjusted it to use Paths.
push_loc() doesn't assume a path, this part tests that self.stack.append(Path.cwd()) works properly.
When we register a location on line 35 we need to make sure we can return to the starting directory by making sure it's on the stack.
|
Will need to resolve comments/conflicts then I approve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make workflow/ensemble/sim dirs easier to read and maintain.