Add gpu/non-gpu resource sets for multi_task support #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranged persistent_sampling and added persistent_sampling_var_resources module. When use_gpus is not given - preferentially use non-gpu resource sets. Check num_procs and num_gpus divide evenly among nodes when schedule rsets. Adjust num_procs and num_gpus with warning when do not fit with num_nodes. Tidy up / reorganize var_resources sim functions.
jlnav
reviewed
May 23, 2023
jlnav
reviewed
May 23, 2023
jlnav
reviewed
May 23, 2023
jlnav
reviewed
May 23, 2023
jlnav
reviewed
May 23, 2023
jlnav
reviewed
May 23, 2023
jlnav
approved these changes
May 23, 2023
jmlarson1
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: When merge, update Optimas branch
Adding gpu/non-gpu resource sets for multi_task support.
Contains a new regression test
test_GPU_variable_resources_multi_task.pyand a functionality test
test_mpi_gpu_settings_mock_nodes_multi_task.pyWhen there are more resource sets on a node than GPUs, some resource sets will be GPU resource sets and some non-GPU resource sets.
The generator specifies, alongside
resource_sets, a booleanuse_gpusas True or False. Both aregen_specs["out"].Alternatively, the generator can specify
num_procsandnum_gpusgen_specs['out'] options