Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6 #89

Closed
3 of 4 tasks
sk1p opened this issue Apr 16, 2024 · 22 comments
Closed
3 of 4 tasks

Release v0.6 #89

sk1p opened this issue Apr 16, 2024 · 22 comments
Milestone

Comments

@sk1p
Copy link
Member

sk1p commented Apr 16, 2024

What's missing, anything TODO before we can cut a release?

TODO

@matbryan52
Copy link
Member

What's missing, anything TODO before we can cut a release?

For me I think it's good-to-go after #90 is sorted.

@sk1p
Copy link
Member Author

sk1p commented Apr 16, 2024

@uellue
Copy link
Member

uellue commented Apr 16, 2024

It seems that the (edit: Zenodo) sandbox parent was nuked some time ago

Maybe one can test against production Zenodo and just doesn't hit the button?

@matbryan52
Copy link
Member

Ran some quick tests with the rc .whl both with and without LiberTEM (py3.10 / ubuntu). All good for the full chain.

I noticed that we don't have a convenience function that will run gridmatching on a frame or stack of frames, you're obliged to run the Matcher yourself or go via the LT / UDF route.

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

Maybe one can test against production Zenodo and just doesn't hit the button?

Implemented in #94 - once that is merged, I'll cut another RC

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

rc2 is building here, let's specifically check the zenodo part: https://github.com/LiberTEM/LiberTEM-blobfinder/actions/runs/8720954308

@uellue
Copy link
Member

uellue commented Apr 17, 2024

RC2 looks good on Zenodo!

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

I'll go ahead and tag v0.6.0 then!

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

pypi upload is failing for some reason, I'll take care of it...

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

pypi upload is failing for some reason, I'll take care of it...

Fixed by rotating credentials: https://pypi.org/project/libertem-blobfinder/

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

I'll go ahead and tag v0.6.0 then!

For some reason, the zenodo part now failed, see the log here: https://github.com/LiberTEM/LiberTEM-blobfinder/actions/runs/8721100857/job/23924930249

@uellue
Copy link
Member

uellue commented Apr 17, 2024

Hm, maybe because I had it open, or because it is irritated by the draft from the RC? Wasn't an issue before, so IDK, try again?

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

GitHub release notes published here: https://github.com/LiberTEM/LiberTEM-blobfinder/releases/tag/v0.6.0

Changelog in the docs still needs to be consolidated.

Hm, maybe because I had it open, or because it is irritated by the draft from the RC? Wasn't an issue before, so IDK, try again?

Hm, can't easily re-run the job, as the zenodo upload comes after pypi, and pypi will complain loudly about the already existing release. Might need to run it carefully, manually (I don't have the credentials for that though).

@uellue
Copy link
Member

uellue commented Apr 17, 2024

What about cutting 0.6.1, and if that shows the same issue I dig out the notebook to run this manually, with keys etc?

@sk1p sk1p added this to the 0.6 milestone Apr 17, 2024
@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

What about cutting 0.6.1, [...]

Ok, I'll do that.

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

I dig out the notebook to run this manually, with keys etc?

Looks like that is needed. I think a good idea would be not to use the notebook, but the release script instead, so we are testing the thing that we are actually running in CI

@uellue
Copy link
Member

uellue commented Apr 17, 2024

Manually it worked

@uellue
Copy link
Member

uellue commented Apr 17, 2024

@uellue
Copy link
Member

uellue commented Apr 17, 2024

@sk1p
Copy link
Member Author

sk1p commented Apr 17, 2024

https://doi.org/10.5281/zenodo.10986304

Still not there btw. - should check again tomorrow and maybe file a support issue with zenodo

@sk1p
Copy link
Member Author

sk1p commented Apr 18, 2024

I'll manually contact the DOI people about the 404, and consider this done.

@sk1p sk1p closed this as completed Apr 18, 2024
@sk1p
Copy link
Member Author

sk1p commented Apr 18, 2024

Released on conda-forge (still waiting for CDN - can be confirmed with conda search libertem-blobfinder) conda-forge/libertem-blobfinder-feedstock#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants