Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate pattern parameters #90

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

uellue
Copy link
Member

@uellue uellue commented Apr 16, 2024

radius_outer <= radius leads to a zero division error, where the cause may not be clear to users.

search < pattern will lead to a truncated pattern and strange cross-correlation results that are probably not what the user intended. UserTemplate would be the right choice for non-standard patterns.

Contributor Checklist:

  • I have added myself to the creators.json file
  • [N/A] I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.90%. Comparing base (13e35ed) to head (e05a97c).

❗ Current head e05a97c differs from pull request most recent head 8c7a163. Consider uploading reports for the commit 8c7a163 to get more accurate results

Files Patch % Lines
src/libertem_blobfinder/common/patterns.py 25.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #90       +/-   ##
===========================================
- Coverage   86.59%   53.90%   -32.70%     
===========================================
  Files          14       14               
  Lines        1179     1191       +12     
  Branches      165      171        +6     
===========================================
- Hits         1021      642      -379     
- Misses        105      513      +408     
+ Partials       53       36       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbryan52 matbryan52 mentioned this pull request Apr 16, 2024
4 tasks
radius_outer <= radius leads to a zero division error, where the
cause may not be clear to users.

search < pattern will lead to a truncated pattern and strange
cross-correlation results that are probably not what the user
intended. UserTemplate would be the right choice for non-standard patterns.
Preparations to run notebooks in CI
Copy link
Member

@matbryan52 matbryan52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't open the notebooks right now, but the code and test changes look good.

@matbryan52 matbryan52 merged commit b5f7142 into LiberTEM:master Apr 16, 2024
17 checks passed
@sk1p sk1p added this to the 0.6 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants