New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test environment without any extras installed #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 86.56% 86.59% +0.03%
==========================================
Files 12 14 +2
Lines 960 1179 +219
Branches 135 165 +30
==========================================
+ Hits 831 1021 +190
- Misses 85 105 +20
- Partials 44 53 +9 ☔ View full report in Codecov by Sentry. |
@uellue @matbryan52 this is the CI addition mentioned in #61 - let me know your thoughts on this, and also feel free to take over the PR |
Thanks for getting this started, I'll see if I can get it into a working state. |
I've ported the necessary bits of code to make tox pass. |
9e725e0
to
7c19604
Compare
I removed the |
I don't really think it is important to be kept, as long as we mention it in the changelog (and update the install docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matbryan52 thank you for taking over!
Should the examples also be updated to replace their usage of libertem.masks
/ libertem.utils
, to make them consistent with the rest of the code? Added a small comment inline, other than that, it looks good to me!
Co-authored-by: Alexander Clausen <alex@gc-web.de>
@matbryan52 thanks for finishing this, I'll go ahead and merge! |
Updates to ensure everything outside the
udf
module can actually be used without installing the full LiberTEM dependency.TODO
libertem
directlybase
common
tests/udf/
)libertem
optionalContributor Checklist: