This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendor the bitshuffle code and generate a binding, which we can then use from Python. This means we don't need to separately install the `bitshuffle` Python package anymore for decompresion.
Only use it for generating the bindings.
sk1p
added a commit
to sk1p/LiberTEM-live
that referenced
this pull request
Aug 25, 2022
5 tasks
In due time we can also link documentation or homepage?
|
Probably a good idea to remove any obvious panic-causes ( |
It is still unclear why it worked on Linux. Co-authored-by: Alexander Clausen <a.clausen@fz-juelich.de>
Fix confirmed for 9c1beaa |
Can't reproduce the CI failure locally, logged it upstream for now: PyO3/maturin-action#99 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the
bitshuffle
code and generate a rust+Python binding. This means we don't need to separately install thebitshuffle
Python package anymore.