Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Add decompression into numpy arrays #10

Merged
merged 13 commits into from Nov 10, 2022
Merged

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Aug 24, 2022

Vendor the bitshuffle code and generate a rust+Python binding. This means we don't need to separately install the bitshuffle Python package anymore.

Vendor the bitshuffle code and generate a binding,
which we can then use from Python. This means we don't need to
separately install the `bitshuffle` Python package anymore for
decompresion.
@sk1p sk1p added the enhancement New feature or request label Aug 24, 2022
sk1p added a commit to sk1p/LiberTEM-live that referenced this pull request Aug 25, 2022
@uellue
Copy link
Member

uellue commented Sep 29, 2022

pytest tests/detectors/dectris with test data hangs on Windows, Python 3.9 with this version and LiberTEM/LiberTEM-live#57. With the released version and the LiberTEM-live master the tests pass.

@sk1p
Copy link
Member Author

sk1p commented Nov 9, 2022

Probably a good idea to remove any obvious panic-causes (unwraps), as windows really doesn't like the worker processes to "go away".

It is still unclear why it worked on Linux.

Co-authored-by: Alexander Clausen <a.clausen@fz-juelich.de>
@uellue
Copy link
Member

uellue commented Nov 9, 2022

pytest tests/detectors/dectris with test data hangs on Windows, Python 3.9 with this version and LiberTEM/LiberTEM-live#57. With the released version and the LiberTEM-live master the tests pass.

Fix confirmed for 9c1beaa

@sk1p
Copy link
Member Author

sk1p commented Nov 9, 2022

Can't reproduce the CI failure locally, logged it upstream for now: PyO3/maturin-action#99

@uellue uellue merged commit 44b098f into LiberTEM:main Nov 10, 2022
uellue pushed a commit to LiberTEM/LiberTEM-live that referenced this pull request Nov 10, 2022
@sk1p sk1p deleted the add-bitshuffle branch November 10, 2022 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants