Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with https://github.com/LiberTEM/LiberTEM/pull/1207/ #68

Merged
merged 6 commits into from Jan 16, 2023

Conversation

uellue
Copy link
Member

@uellue uellue commented Jan 13, 2023

On my system I get test failures from access violations, but I assume they are unrelated.

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • [N/A] I have added/updated documentation for all user-facing changes
  • [N/A] I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

On my system I get test failures from access violations, but I assume
they are unrelated.
@uellue uellue added this to the 0.2 milestone Jan 13, 2023
@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Also make mypy a bit happier
@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue uellue requested a review from sk1p January 13, 2023 11:33
@uellue
Copy link
Member Author

uellue commented Jan 13, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 73.44% // Head: 73.37% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (0a2ee92) compared to base (f44d3d8).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   73.44%   73.37%   -0.08%     
==========================================
  Files          23       23              
  Lines        2463     2464       +1     
  Branches      387      342      -45     
==========================================
- Hits         1809     1808       -1     
  Misses        550      550              
- Partials      104      106       +2     
Impacted Files Coverage Δ
src/libertem_live/detectors/dectris/acquisition.py 81.69% <83.33%> (+0.61%) ⬆️
src/libertem_live/detectors/merlin/acquisition.py 93.49% <100.00%> (-0.53%) ⬇️
src/libertem_live/api.py 91.89% <0.00%> (-8.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sk1p sk1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some fixes for new tox version, now it LGTM!

@sk1p sk1p merged commit 442b00f into LiberTEM:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants