Add experimental ASI TPX3 Support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 77.13% 79.24% +2.11%
==========================================
Files 31 35 +4
Lines 2943 3359 +416
Branches 410 446 +36
==========================================
+ Hits 2270 2662 +392
- Misses 544 561 +17
- Partials 129 136 +7
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* In some cases, the detector may have the concrete `nav_shape` available, then it doesn't make sense to start guessing * Add pytest fixtures for asi tpx3 simulator etc. * Start work on ASI TPX3 docs
* uri -> data_host + data_port * num_slots -> buffer_size * Add (hopefully reasonable?) defaults for bytes_per_chunk / chunks_per_stack etc.
Make sure we correctly update our tracking of `passive_started`, so we try to restart passive mode after reconnecting. Also add tests for coverage of the asi_tpx3 sim
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Don't use such a low value - for sparse data, much larger partition sizes are efficient.
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Let's merge with debug output and see where it goes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently includes #74 - once that is merged, I'll rebase. Fixes #77
TODO
For the first experimental version, the following should be sufficient:
LiveContexturivs.data_host+data_port)simto conform to our generic simulator interfaceconftest.pyfor docstrings, in a autouse fixture; alsoasi_tpx3/conftest.pyContributor Checklist:
Reviewer Checklist:
/azp run libertem.libertem-live-datapassed