Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5: Fix crash w/ full_frame + no tileshape param #608

Merged
merged 2 commits into from Feb 18, 2020

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Feb 18, 2020

Contributor Checklist:

@sk1p sk1p added bug Something isn't working file formats and I/O labels Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #608 into master will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   57.47%   58.43%   +0.95%     
==========================================
  Files         208      209       +1     
  Lines        7923     8101     +178     
  Branches     1038     1096      +58     
==========================================
+ Hits         4554     4734     +180     
- Misses       3175     3177       +2     
+ Partials      194      190       -4     
Impacted Files Coverage Δ
src/libertem/utils/async_utils.py 100.00% <0.00%> (ø)
src/libertem/io/dataset/hdf5.py 90.62% <0.00%> (+1.25%) ⬆️
src/libertem/api.py 89.69% <0.00%> (+1.63%) ⬆️
src/libertem/web/dataset.py 77.52% <0.00%> (+2.23%) ⬆️
src/libertem/web/base.py 95.18% <0.00%> (+3.31%) ⬆️
src/libertem/web/jobs.py 70.96% <0.00%> (+4.58%) ⬆️
src/libertem/io/dataset/__init__.py 91.30% <0.00%> (+18.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd618f7...e0be36d. Read the comment docs.

@sk1p sk1p merged commit 5875954 into LiberTEM:master Feb 18, 2020
@sk1p sk1p deleted the hdf5_full_frames_auto_tileshape branch February 18, 2020 13:01
@sk1p sk1p added this to the 0.5 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working file formats and I/O
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant