Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: DID resolver #724

Closed
wants to merge 9 commits into from
Closed

Spike: DID resolver #724

wants to merge 9 commits into from

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented Nov 29, 2022

Goal

The goal of this PR is to make a Frequency-DSNP-DID resolver RPC endpoint.

Closes #685
Partially blocked by #474 fetching keys for a given MSA ID

Discussion

Creates a couple of RPC endpoints, one of which returns a DID document for an ID if it's an MSA. The others are TBD

Checklist

  • Updated js/api-augment.
  • Tests added

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #724 (61a75a6) into main (ec9ab3a) will increase coverage by 0.77%.
The diff coverage is 85.48%.

❗ Current head 61a75a6 differs from pull request most recent head 8e7f6e8. Consider uploading reports for the commit 8e7f6e8 to get more accurate results

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   79.58%   80.36%   +0.77%     
==========================================
  Files          19       20       +1     
  Lines         823      886      +63     
==========================================
+ Hits          655      712      +57     
- Misses        168      174       +6     
Impacted Files Coverage Δ
pallets/msa/src/rpc/src/lib.rs 51.72% <80.00%> (+51.72%) ⬆️
pallets/msa/src/lib.rs 84.68% <87.50%> (+0.46%) ⬆️
common/primitives/src/did.rs 94.73% <94.73%> (ø)
pallets/messages/src/lib.rs 86.17% <0.00%> (-0.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shannonwells shannonwells force-pushed the feat/dids branch 2 times, most recently from 02977b9 to 61a75a6 Compare December 5, 2022 23:21
@shannonwells shannonwells changed the title Feat/dids Spike: DID resolver Dec 8, 2022
@wilwade
Copy link
Collaborator

wilwade commented Feb 1, 2023

Closing out the spike, but retaining branch.

@wilwade wilwade closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preliminary DIDs <--> MSAs resolver
2 participants