Add null pages and boundary order (Fixes #92) #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Parquet file column indexes are required to have
null_pages
andboundary_order
, but they were missing from Parquetjs generated files.https://github.com/apache/parquet-format/blob/1603152f8991809e8ad29659dffa224b4284f31b/src/main/thrift/parquet.thrift#L955
Closes #92
Solution
Note: While required, the requirement is not always a hard requirement depending on the library.
Steps to Verify:
npm i && npm run build && npm pack
brew install parquet-cli
)cd parquetjs_bug/parquetjs && npm i
node index.js && parquet column-index ../generated_files/parquetjs/change.parque
will FAIL8
node index.js && parquet column-index ../generated_files/parquetjs/change.parque
will PASS!