Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest of the Current DSNP Schemas #4

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Rest of the Current DSNP Schemas #4

merged 7 commits into from
Aug 16, 2022

Conversation

wilwade
Copy link
Member

@wilwade wilwade commented Aug 15, 2022

Problem

Need to define the Frequency Schemas for the rest of the current DSNP Announcement Types

Part of LibertyDSNP/spec#191

Solution

  • Refactored the Parquet Tests to make them reusable
  • Added the schemas for:
    • Update
    • Reply
    • Reaction
    • Tombstone
    • Profile

Steps to Verify:

  1. Run the tests
  2. Each announcement should match the spec here: https://spec.dsnp.org/DSNP/Announcements.html

@wilwade wilwade mentioned this pull request Aug 15, 2022
Closed
shannonwells
shannonwells requested changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere there is an announcementType it's set to 16-bit width, but in the spec it's an Int32.

dsnp/tombstone.ts Outdated Show resolved Hide resolved
dsnp/profile.ts Outdated Show resolved Hide resolved
dsnp/reaction.ts Outdated Show resolved Hide resolved
dsnp/tombstone.ts Outdated Show resolved Hide resolved
dsnp/update.ts Outdated Show resolved Hide resolved
saraswatpuneet
saraswatpuneet approved these changes Aug 16, 2022
View reviewed changes
Copy link

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval contingent on @shannonwells catch 🗡️

shannonwells
shannonwells approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go with me

@wilwade wilwade merged commit df25a98 into main Aug 16, 2022
@wilwade wilwade deleted the initial-dsnp-schemas-191 branch August 16, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonwells shannonwells shannonwells approved these changes

@enddynayn enddynayn enddynayn approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilwade @shannonwells @enddynayn @saraswatpuneet