Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIP-158 Make published required in Activity Content Type Note #158

Closed
3 tasks
wilwade opened this issue Mar 31, 2022 · 0 comments · Fixed by #163
Closed
3 tasks

DIP-158 Make published required in Activity Content Type Note #158

wilwade opened this issue Mar 31, 2022 · 0 comments · Fixed by #163
Milestone

Comments

@wilwade
Copy link
Member

wilwade commented Mar 31, 2022

Abstract

While updating #145 and then #148 we realized that content hashes should be "required" to be unique, achievable via making the published field required.

Motivation

  • We want users to still be able to publish the same content more than once, but have replies, reactions, and other references be separated. (For example, "Good morning!")

Specification Pull Request

Current change pull request: TODO

Additional Actions

  • Create story in activity-content to update requirement
  • Create story in activity-content-java to update requirement
  • Create story in activity-content-swift to update requirement

Rationale

The other alternatives required more on chain data. This reduces the on chain data while still maintaining the same level of trust.

Requiring published on the Profile type does not appear to be necessary as it already uses a last profile wins resolution algorithm.

Backwards Compatibility

  • While this is a breaking change, as of this publishing no content exists without said value. It is already the effective default

Security Considerations

While users could lie about the date, as duplicate Announcements are ignored, the purpose of generating unique hashes is as secure as it was before.

Dependencies

None

References

Copyright

Copyright and related rights waived via CC0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant