Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for DSNP v1.2.0 #19

Closed
1 of 2 tasks
wilwade opened this issue Apr 10, 2023 · 0 comments · Fixed by #22
Closed
1 of 2 tasks

Update for DSNP v1.2.0 #19

wilwade opened this issue Apr 10, 2023 · 0 comments · Fixed by #22
Assignees
@wilwade

Comments

@wilwade
Copy link
Member

wilwade commented Apr 10, 2023 •
edited

The DSNP Spec is preparing to release v1.2.0 with a few minor changes to the Activity Content portion of the Spec.
@wilwade wilwade added the good first issue Good for newcomers label Apr 10, 2023
@wilwade wilwade mentioned this issue Apr 10, 2023
Closed
@wilwade wilwade self-assigned this Jun 12, 2023
This was referenced Jun 13, 2023
Merged
Merged
@wilwade wilwade removed the good first issue Good for newcomers label Jun 20, 2023
wilwade added a commit that referenced this issue Jun 20, 2023
@wilwade
[DSNP 1.2.0] Breaking Change: Use multiformat hashes (#22)
7aa4074 
Problem
=======
DSNP 1.2.0 updated to use multiformat hashes instead of the pre-1.2.0
object format.

Closes: #19 

Solution
========
- Removed the old way completely as it was in limited use.
- Updated to the new setup for validating and creating
- Added some additional utilities around hashing.

Double Checks:
---------------
- [x] Did you update the changelog?
- [x] Any new modules need to be exported?
- [x] Are new methods in the right module?
- [x] Do you have good documentation on exported methods?

Change summary:
---------------
* Lots of tests to update
* Added the new multiformat dependencies
* Removed js-sha3 dependency
* Updated how jest runs tests some to support TextEncoder
* Now compiles the esm version instead of the commonjs version as most
things support both now.

Steps to Verify:
----------------
This is not so easy, as there are not many sites out there to build
multiformat hashes. I suggest looking closely at the tests, and perhaps
creating some against it yourself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilwade wilwade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DSNP 1.2.0] Breaking Change: Use multiformat hashes LibertyDSNP/activity-content
1 participant
@wilwade