-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frequency Graph User Data #240
Conversation
df3a9ec
to
f8fc538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just had a tiny suggestion that is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking into the details of how libsodium library and how it needs to get build on each platform and architecture differently and considering that we would need to create bridges for our Rust library on top of this, then it's self evident that how complicated this might become.
I'm recommending to use a Rust native implementation of libsodium. crypto_box
crate has the same seal
and unseal
functionality which is compatible with libsodium.
Other functionalities used in libsodium like crypto_box_beforenm
and crypto_kdf_derive_from_key
, crypto_secretbox_detached
are kinda very niche use-cases and not directly implemented in it but we can reach the same result (more or less) with some other Rust libraries.
In general I'm suggesting to use more mainstream functions and definitions for above functionalities if possible.
f8fc538
to
acfa7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added a couple of questions and comments.
acfa7e8
to
fec4e8c
Compare
Problem
Update the Frequency Implementation post #233 and #226
Closes #239
Solution