Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency Graph User Data #240

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Frequency Graph User Data #240

merged 3 commits into from
Apr 4, 2023

Conversation

wilwade
Copy link
Member

@wilwade wilwade commented Mar 10, 2023

Problem

Update the Frequency Implementation post #233 and #226

Closes #239

Solution

  • Added Frequency/UserData.md
  • Added PublicKey Announcement
  • Added information about the Stateful Storage Pallet
  • Updated other related tables.

@wilwade wilwade force-pushed the frequency/graph-user-data-239 branch from df3a9ec to f8fc538 Compare March 10, 2023 20:19
Base automatically changed from proposal/DIP-225_DIP-227_Graph_and_User_Data_Operations to main March 10, 2023 22:35
Copy link
Contributor

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had a tiny suggestion that is non-blocking.

pages/Frequency/Operations.md Outdated Show resolved Hide resolved
pages/DSNP/UserData.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking into the details of how libsodium library and how it needs to get build on each platform and architecture differently and considering that we would need to create bridges for our Rust library on top of this, then it's self evident that how complicated this might become.
I'm recommending to use a Rust native implementation of libsodium. crypto_box crate has the same seal and unseal functionality which is compatible with libsodium.
Other functionalities used in libsodium like crypto_box_beforenm and crypto_kdf_derive_from_key, crypto_secretbox_detached are kinda very niche use-cases and not directly implemented in it but we can reach the same result (more or less) with some other Rust libraries.

In general I'm suggesting to use more mainstream functions and definitions for above functionalities if possible.

pages/DSNP/Graph.md Outdated Show resolved Hide resolved
pages/DSNP/Graph.md Outdated Show resolved Hide resolved
pages/DSNP/Graph.md Outdated Show resolved Hide resolved
@wilwade wilwade force-pushed the frequency/graph-user-data-239 branch from f8fc538 to acfa7e8 Compare March 24, 2023 19:35
@wilwade wilwade marked this pull request as ready for review March 24, 2023 20:07
Copy link
Contributor

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a couple of questions and comments.

pages/Frequency/Publishing.md Show resolved Hide resolved
pages/Frequency/Records.md Outdated Show resolved Hide resolved
@wilwade wilwade force-pushed the frequency/graph-user-data-239 branch from acfa7e8 to fec4e8c Compare April 4, 2023 13:06
@wilwade wilwade merged commit 11bc0a3 into main Apr 4, 2023
@wilwade wilwade deleted the frequency/graph-user-data-239 branch April 4, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSNP Implementation Update: Graph
3 participants