DIP-263 Use User Data for Public Keys #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
reviewed
Apr 12, 2024
pages/DSNP/UserData.md
Outdated
| @@ -190,12 +191,12 @@ The following example illustrates the output of a Get User Data Operation invoca | |||
| { | |||
| "data": base64_string, | |||
| "etag": string, | |||
| "keyId": integer | |||
| "keyIndex": integer | |||
There was a problem hiding this comment.
Would this be a change to the https://github.com/LibertyDSNP/graph-sdk/ that needs to happen?
There was a problem hiding this comment.
I don't think this "example" JSON serialization is used directly in graph-sdk, but @aramikm or Joe might know better. I'll get some more eyes on it. If there's prior art out there using keyId I'd be fine with keeping it that way for simplicity's sake, but documenting that keyId is the index.
There was a problem hiding this comment.
Per Joe this won't impact graph-sdk, so resolving this thread.
There was a problem hiding this comment.
After thinking about this, I think this should just keep keyId. It is an identifier even if it applies an index algo.
wilwade
reviewed
Apr 12, 2024
wesbiggs
force-pushed
the
proposal/DIP-263_Use_User_Data_for_Public_Keys
branch
from
4391c5d
to
5e03123
Compare
wilwade
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #263
Solution