Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Sutton and Blackpool #30

Merged
merged 16 commits into from Feb 11, 2023
Merged

Conversation

cpwood
Copy link
Contributor

@cpwood cpwood commented Feb 11, 2023

Blackpool

In creating the Luci connector, I accidentally broke Blackpool because there were two functions with the same name in the global namespace.

I've made the two functions distinctly named, for now, but the code might benefit from switching to actual classes at some point in the future. If you have any strong objections, let me know? Historically, I'd hesitate doing that kind of thing if the library would be used in a browser, but there are so many CORS restrictions now that I can't conceive that this library would be used in that way.

Sutton

Since Luci is in beta with Sutton at the moment, I think we can expect a few breaking changes. This was one of them: an extra header is now required in the HTTP request to retrieve the details of a book.

Shetland Islands

Tests are failing because no books in the entire library seem to have availability information, suddenly. They might be changing to another platform, but can't see any hint of that yet on their web site.

@DaveBathnes
Copy link
Member

Thanks for these!

On browser - I think the exception is I've been planning to use the library in a Chromium extension. That's essentially browser, but with some options for no CORS restrictions. (It gets complex, I think the background process that runs on a page has the normal restrictions but the plugin window doesn't).

Of course there are still options to make the code usable in the browser, but just go through a compiler first.

@DaveBathnes DaveBathnes merged commit cbd751c into LibrariesHacked:main Feb 11, 2023
@DaveBathnes
Copy link
Member

I think Browser support (sorry, things coming back to me) partly the reason behind some of the packages chosen - superagent and the polyfill one. But will check that out!

Otherwise nothing in theory against refactoring, but browser support would be worth retaining I think. I can always do the testing for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants