Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 2019 Lesson Release checklist #40

Open
fmichonneau opened this issue Apr 16, 2019 · 17 comments

Comments

Projects
None yet
6 participants
@fmichonneau
Copy link
Member

commented Apr 16, 2019

If your Maintainer team has decided not to participate in the June 2019 lesson release, please close this issue.

To have this lesson included in the 18 June 2019 release, please confirm that the following items are true:

  • Example code chunks run as expected
  • Challenges / exercises run as expected
  • Challenge / exercise solutions are correct
  • Call out boxes (exercises, discussions, tips, etc) render correctly
  • A schedule appears on the lesson homepage (e.g. not “00:00”)
  • Each episode includes learning objectives
  • Each episode includes questions
  • Each episode includes key points
  • Setup instructions are up-to-date, correct, clear, and complete
  • File structure is clean (e.g. delete deprecated files, insure filenames are consistent)
  • Some Instructor notes are provided
  • Lesson links work as expected

When all checkboxes above are completed, this lesson will be added to the 18 June lesson release. Please leave a comment on carpentries/lesson-infrastructure#26 or contact Erin Becker with questions (ebecker@carpentries.org).

@libcce

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

I believe we can release this lesson, what does everyone @ppival @ostephens @partiecolored @pitviper6 @kristindawn @ccronje think? Vote with a thumbs up on the initial issue above if you think so. This is one of the most stable lessons in Library Carpentry and it would be nice to give credit to all of the contributors 😃 To start, I checked the lesson links and made the following PRs:

Otherwise, all the other links work.

@libcce

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Regarding the instructor notes, I've submitted #45. I created a draft md in 'files' from my instructor outline/notes for a workshop I taught at UNC https://github.com/LibraryCarpentry/lc-open-refine/blob/gh-pages/files/draft-instructor-notes.md. I wonder if others who have taught OpenRefine recently can add/modify it @annaoates @JordanPedersen @rwangca @pitviper6 @JoshuaDull @mpfl ?

@libcce

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

I checked off "Call out boxes (exercises, discussions, tips, etc) render correctly" since all appear to work properly.

@partiecolored

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

I checked off the items about questions, objectives, and key points, and instructor notes

@ostephens

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

All PRs by @libcce to fix lesson links now merged - so have checked that off

@ostephens

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

All episodes have timings, so the lesson schedule displays correctly. Have checked that off

@libcce

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@fmichonneau the OpenRefine lesson will be ready for The Carpentries lesson release. 3 of the lesson Maintainers have voted to do this. We've already started to check off items on the release list as well.

@ErinBecker

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Awesome! Thanks @libcce for letting us know.

@ErinBecker ErinBecker added this to the June 2019 Release milestone May 15, 2019

@libcce

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Checked off:
Example code chunks run as expected
Challenges / exercises run as expected
Challenge / exercise solutions are correct

Raised issue #65 and two PRs #66 and #64 with minor corrections.

@libcce

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Setup has recently been updated:

  • language asking people to download the latest tested version
  • troubleshooting links
    Checked off!
@libcce

This comment has been minimized.

Copy link
Member

commented May 21, 2019

For the last item, file structure, do we need the autumn and spring images in the files folder? https://github.com/LibraryCarpentry/lc-open-refine/tree/gh-pages/files
Otherwise, I think everything else checks out.

@ostephens

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

Thanks @libcce done a PR to remove those files

@libcce

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@ostephens all set then! List is checked off @ErinBecker!

@jyssy

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Wow - awesome. I had planned to come back to this next week when a little more bandwidth opened. Super

@libcce

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Oh! I forgot @jyssy! Any interest in the SQL lesson 😉 We need help there 😄

@jyssy

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Let me look... thanks

@ostephens

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

Thanks to all who helped with this and to @libcce for keeping us at it until we got over the line :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.