Clarify issues links in CONTRIBUTING.md #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
morskyjezek
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks. These also address the issues noted by Toby in #138
|
Just to clarify, it addresses point 1 in #138 , but you will still need to make the change raised in point 2 (updating the FIXME link to this repository). You can do that by adding a commit to the PR, or by making the change is a separate PR after merging this one. |
morskyjezek
added a commit
that referenced
this pull request
Jun 24, 2023
morskyjezek
added a commit
that referenced
this pull request
Jun 24, 2023
…inks add repo link for contributing to complete PR #140. This should complete basic updates of the CONTRIBUTING.md file following the transition to the Workbench lesson structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is being submitted to all repos that have been converted to Workbench, so that they reflect a recent update in the Workbench template. The change is probably appropriate for your repository, but you may disagree. I encourage you to look at a description of the problem it fixes found in this comment of this issue.
You will still need to replace
example.com/FIXMEin the [repo] and [repo-issues] link targets with this repository.It additionally fixes the broken [how-contribute] link.