-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor copyedit to introductory paragraph #145
Minor copyedit to introductory paragraph #145
Conversation
Changed the language about the purpose of this lesson.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-spreadsheets/compare/md-outputs..md-outputs-PR-145 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-08-18 17:05:02 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent point! Well phrased. I'm not the maintainer here to push it through tho.
Thanks! This is nice improvement to the lesson. |
Auto-generated via {sandpaper} Source : 24074de Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-18 18:06:04 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : ca817cf Branch : main Author : Jesse Johnston <morskyjezek@gmail.com> Time : 2023-12-18 18:05:03 +0000 Message : Merge pull request #145 from emcaulay/emcaulay-index-page-update Minor copyedit to introductory paragraph
Auto-generated via {sandpaper} Source : 24074de Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-18 18:06:04 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : ca817cf Branch : main Author : Jesse Johnston <morskyjezek@gmail.com> Time : 2023-12-18 18:05:03 +0000 Message : Merge pull request #145 from emcaulay/emcaulay-index-page-update Minor copyedit to introductory paragraph
I updated the statement in the introductory paragraph on the index page of this lesson because I thought the phrasing was incorrect. The original sentence said that the purpose of the lesson was to teach people interested in using "Library Carpentry data in spreadsheets." I do not think the intended audience for the lesson is people wanting to work with "Library Carpentry data." I think it was an unintentional error, and I hope my revision clarifies what the purpose of the lesson is.