Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden folders are included in bag despite includeHidden setted to false #101

Closed
tiarossi opened this issue Jan 15, 2018 · 1 comment
Closed

Hidden folders are included in bag despite includeHidden setted to false #101

tiarossi opened this issue Jan 15, 2018 · 1 comment
Labels
bug

Comments

@tiarossi
Copy link

tiarossi commented Jan 15, 2018 •
edited by johnscancella
Loading

Version : 5.0.3
OS: Windows 7

When

  • I run testBagInPlace at BagCreatorTest

Then

  • I should not see ".hiddenFolder" at the created bag

Error
At BagCreator::moveDataFilesIfNeeded, Files.isHidden is used to test directory hiddeness. But from method javadoc "On Windows a file is considered hidden if it isn't a directory and the DOS hidden attribute is set."
johnscancella added a commit that referenced this issue Jan 16, 2018
@johnscancella
refs #101 - make sure we test using the dos property for a file being…
b7c3f0c 
… hidden on windows
@johnscancella
Copy link
Contributor

Hi @tiarossi,

Thank you for reporting this. It should be fixed in the next release 5.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiarossi @johnscancella