Gracefully handle invalid modes #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we not check if the mode value contains transcribe or review, rather than checking for exact matches? That way we could still load the requested mode even with the incorrect URL. |
|
My feeling was that it was better just to fallback to review mode than to attempt to salvage it but since we're talking n=2 here we could do something like |
|
Works for me |
rstorey
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gracefully handles typos like
https://crowd.loc.gov/act/#mode=review?loclr=twcwdwhich caused the first asset load to fail because it's given a mode which could not normally occur.