Simple content blocks #1060
Merged
Simple content blocks #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Jun 17, 2019
acdha
reviewed
Jun 17, 2019
…r style to simple pages
…s if feature flag is enabled
rstorey
force-pushed
the
simple-content-blocks
branch
from
18812ed
to
4b89e78
Compare
acdha
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
I'd probably write this using SimpleContentBlock.DoesNotExist since that avoids the extra import and has a benefit in more complicated code of not catching exceptions from an unexpected object but for something like this it's really not worth spending more time on.
That answers a question I had in my head after reading the Django docs. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the last item in #901
Content blocks must be predefined in the code with a label. That label is then used to populate the content block in the database through the Django admin. A feature flag is used to globally enable or disable the usage of these content blocks.
It's expected that this feature will be used for the Quick Tips section in the classic UI and the Help side panel in the activity UI.
This PR is built on the admin-enhancements branch.