Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin filters #1068

Merged
merged 3 commits into from Jul 1, 2019
Merged

Admin filters #1068

merged 3 commits into from Jul 1, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Jun 26, 2019

Refs #900

This PR reorders some of the list filters in the Django admin site so that filters with many options are lower down in the page, and more commonly used filters with fewer options are at the top.

@rstorey rstorey self-assigned this Jun 26, 2019
@rstorey rstorey requested a review from acdha June 26, 2019 17:45
@rstorey rstorey added this to In progress in Sprint 24 June 10 - July 22 Jun 27, 2019
acdha
acdha previously approved these changes Jul 1, 2019
Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should also change the created_by filters to restrict their values to is_staff=True users since that'll remove almost all of the entries with no loss in functionality.

Project might also benefit from using select2 for the dropdown-with-autocomplete behaviour rather than a flat list.

@rstorey rstorey merged commit 1c048b8 into master Jul 1, 2019
Sprint 24 June 10 - July 22 automation moved this from In progress to Done Jul 1, 2019
@rstorey rstorey deleted the admin-filters branch July 1, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants